perf(parser): make Kind::Eof (default) 0#11014
Merged
graphite-app[bot] merged 1 commit intomainfrom May 14, 2025
Merged
Conversation
github-actions
bot
added
A-parser
This was referenced May 13, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11014 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
05-13-refactor_lexer_harden_safety_of_transmute
to
graphite-base/11014
graphite-app
bot
force-pushed
the
graphite-base/11014
branch
from
3f7dad1 to
c0b68eb
Compare
graphite-app
bot
force-pushed
the
05-13-perf_parser_make_kind_eof_default_0
branch
from
4517605 to
656857f
Compare
graphite-app
bot
force-pushed
the
05-13-perf_parser_make_kind_eof_default_0
branch
from
656857f to
63ff506
Compare
overlookmotel
force-pushed
the
05-13-perf_parser_make_kind_eof_default_0
branch
from
63ff506 to
5eeaac4
Compare
Member
Author
|
+1% on lexer benchmarks. +0.4% - +0.2% on parser benchmarks. |
Member
Merge activity
|
Follow-on after #10933. Make `u8` value of `Kind::Eof` (`Kind::default()`) be 0. This makes `Token::default()` a little cheaper, as all bits of default `Token` are 0.
graphite-app
bot
force-pushed
the
05-13-perf_parser_make_kind_eof_default_0
branch
from
5eeaac4 to
a711ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #10933. Make
u8value ofKind::Eof(Kind::default()) be 0. This makesToken::default()a little cheaper, as all bits of defaultTokenare 0.